Skip to content

🐛 [#626] Use raw_id_fields for klantcontact and other missing FK r… - #661

Merged
stevenbal merged 2 commits into
masterfrom
issue/626-betrokkene-raw-id-fields
Sep 8, 2026
Merged

🐛 [#626] Use raw_id_fields for klantcontact and other missing FK r…#661
stevenbal merged 2 commits into
masterfrom
issue/626-betrokkene-raw-id-fields

Conversation

@OlhaZahoruiko

@OlhaZahoruiko OlhaZahoruiko commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

…elations

Fixes #626

Changes

  • Fix the Betrokkenen bij klantcontact admin timeout by rendering the klantcontact relation with raw_id_fields instead of loading all Klantcontact records into a dropdown
  • Optimize other FK relations in the admin with raw_id_fields
  • Add a Django system check to detect unoptimized FK relations in registered admins and inlines

Checklist

  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how
  • Architectural design record

    • If a design decision was made that changes functionality, create an architectural design record for it here

@codecov-commenter

codecov-commenter commented Sep 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.43503% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 98.00%. Comparing base (4cd0082) to head (51a0d5c).

Files with missing lines Patch % Lines
src/openklant/utils/checks.py 98.48% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #661      +/-   ##
==========================================
+ Coverage   97.98%   98.00%   +0.02%     
==========================================
  Files         238      241       +3     
  Lines       14069    14245     +176     
==========================================
+ Hits        13785    13961     +176     
  Misses        284      284              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@OlhaZahoruiko
OlhaZahoruiko force-pushed the issue/626-betrokkene-raw-id-fields branch from cdb69f9 to 554251d Compare September 7, 2026 09:15
@OlhaZahoruiko OlhaZahoruiko changed the title bug: [#626] Use raw_id_fields for klantcontact and other missing FK r… 🐛 [#626] Use raw_id_fields for klantcontact and other missing FK r… Sep 7, 2026
@OlhaZahoruiko
OlhaZahoruiko force-pushed the issue/626-betrokkene-raw-id-fields branch from 554251d to 1dd502f Compare September 7, 2026 09:22
@OlhaZahoruiko
OlhaZahoruiko marked this pull request as ready for review September 7, 2026 09:35
Comment thread src/openklant/components/klantinteracties/admin/partijen.py
Comment thread src/openklant/utils/checks.py Outdated
@OlhaZahoruiko
OlhaZahoruiko force-pushed the issue/626-betrokkene-raw-id-fields branch from 5b58648 to 992f9de Compare September 7, 2026 12:26
@OlhaZahoruiko
OlhaZahoruiko force-pushed the issue/626-betrokkene-raw-id-fields branch from 992f9de to 51a0d5c Compare September 7, 2026 12:28
@stevenbal
stevenbal merged commit 90fe1ec into master Sep 8, 2026
31 checks passed
@stevenbal
stevenbal deleted the issue/626-betrokkene-raw-id-fields branch September 8, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Viewing "Betrokkenen bij klantcontact" in the admin with a large amount of "klantcontacten" isn't possible

3 participants