This repository was archived by the owner on Dec 27, 2022. It is now read-only.
Dependency update: markdown-it 13, mini->micromatch, etc.#22
Open
zackw wants to merge 3 commits intomayo:masterfrom
Open
Dependency update: markdown-it 13, mini->micromatch, etc.#22zackw wants to merge 3 commits intomayo:masterfrom
zackw wants to merge 3 commits intomayo:masterfrom
Conversation
Lockfiles shouldn't exist at all, actually, but most of the harm they do can be mitigated by keeping them as ephemeral as possible. In particular, they should not be committed to version control ever.
debug ^3.2.6 -> ^4.3.0 markdown-it ^8.4.2 -> ^13.0.0 minimatch ^3.0.4 -> micromatch ^4.0.0 (following metalsmith core) mocha 5.x -> ^10.1.0 metalsmith 2.x -> ^2.5.0 assert-dir-equal 1.x -> ^1.1.0 markdown-it-abbr ^1.0.4 -> ^1.0.0 (don’t depend on a specific patch level) Code changes required: - minimatch -> micromatch - minimatch.filter -> micromatch() - new Buffer -> Buffer.from() Fixes 5 ‘npm audit’ complaints. Two more were already addressed by deleting the lockfile.
- Add a basic, hopefully uncontroversial ESLint and Prettier configuration. Run this on every commit using husky and lint-staged. Prettier is not applied to Markdown or HTML files, as good formatting for those is much more subjective. To reduce churn, Prettier is configured to prefer single-quoted strings. However, it is _not_ configured to leave out any semicolons, despite the substantial churn on that point, since I consider ASI to be an egregious misfeature. - The only _functional_ code change was the removal of an unnecessary import from test/index.js. - Flesh out the .editorconfig a bit, to match the linters.
Author
|
Would close #19. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This plugin hasn't had its dependencies updated in quite some time and
npm auditis quite cranky about it. Here's a PR which updates everything. Note in particular the change from minimatch to micromatch, which was not strictly necessary but aligns behavior better with metalsmith core. All tests pass.As you can probably tell from the other two commits in this PR I have some pretty strong opinions about how things should be done, let me know if any of that doesn't suit you.