fix: submit download tasks sequentially to preserve input order#834
Open
hackeriori wants to merge 1 commit into
Open
fix: submit download tasks sequentially to preserve input order#834hackeriori wants to merge 1 commit into
hackeriori wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When submitting multiple download links at once (e.g., TV episodes), the order of tasks in aria2's waiting queue becomes scrambled. The task that starts downloading first is not necessarily the first link submitted, forcing users to manually reorder tasks by drag-and-drop.
Root Cause
AriaNg submitted all URLs simultaneously via
aria2RpcService.addUriMulti, which calls$q.all(promises)to fire allaria2.addUriRPC requests in parallel. Since all requests reach aria2 at nearly the same time, aria2's internal queue manager may assign GIDs and positions arbitrarily, losing the user's intended order.Solution
Replace parallel batch submission with sequential chained submission — each task is submitted only after the previous one's response is received, ensuring aria2 receives them in the exact order the user provided.
Changes
src/scripts/services/aria2TaskService.js— AddednewUriTasksSequentiallymethod that uses promise chaining (.then()/.catch()) to submit tasks one by one. Aggregates individual responses into a combined response matching the existing callback format. Follows the same pattern already used by the existingretryTasksmethod.src/scripts/controllers/new.js— ChangeddownloadByLinksto callnewUriTasksSequentiallyinstead ofnewUriTasks.Fixes #833