fix(deps): remediate 2 critical npm advisories in React frontend - #224
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Mason <masonbatchelor81@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependency audit of TraderX found 2 CRITICAL npm advisories in
web-front-end/react(backendpip-auditwas clean). This appliesnpm audit fix— lockfile-only, nopackage.json/ direct-dependency changes, no breaking upgrades.Critical fixes (both transitive under
react-scripts):shell-quote1.8.3 → 1.10.0 — GHSA-w7jw-789q-3m8p (newline escaping inquote()), GHSA-395f-4hp3-45gv (quadratic-complexity DoS inparse())websocket-driver0.7.4 → 0.7.5 — GHSA-mp7j-qc5w-4988 (compression resource-limit bypass), GHSA-xv26-6w52-cph6 (message corruption via protocol length headers)Also picked up in the same non-breaking pass (runtime path via
socket.io-client):socket.io-parser4.2.5 → 4.2.7,ws8.18.3/8.19.0 → 8.21.3,engine.io-client6.6.4 → 6.6.6Result:
npm auditgoes 54 → 30 vulnerabilities, 0 critical remaining. Remaining 30 (15 high) are all dev-only chains underreact-scripts@5.0.1(webpack-dev-server/sockjs/uuid,underscoreviajsonpath/bfj) that onlynpm audit fix --forcewould touch, which downgradesreact-scriptsto0.0.0— deliberately not done here.Verified:
npm run buildcompiles successfully andnpm run lintis clean.Link to Devin session: https://app.devin.ai/sessions/ab88829c7e8943d580fe601ff5999065
Open in Devin Desktop: https://app.devin.ai/desktop/session/ab88829c7e8943d580fe601ff5999065?variant=devin
Requested by: @mbatchelor81