fix(deps): patch 2 critical npm CVEs via shell-quote / websocket-driver overrides - #232
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…l CVEs Co-Authored-By: Mason <masonbatchelor81@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Runtime smoke test — dependency overrides verified end-to-endSince this PR only pins socket.io real-time update works — new trade lands in both blotters with no page reloadSubmitted Backend confirmed the publishes: Dev server boots clean & blotters load with seed data
HMR over the dev-server websocket (the discriminating test for websocket-driver)Edited the Browser console contained zero entries matching |
Summary
npm auditinweb-front-end/reactreports 55 vulnerabilities, 2 of them CRITICAL. Both are transitive underreact-scripts@5.0.1, which pins them below the patched releases, so they can only be lifted withoverrides:Chains:
react-dev-utils/launch-editor→shell-quote, andwebpack-dev-server→sockjs(+faye-websocket) →websocket-driver.Both patched versions are semver-minor/patch and API-compatible;
npm run buildcompiles successfully andnpm auditnow reports 0 critical (53 remaining: 12 low, 12 moderate, 29 high).The remaining HIGH findings are not addressed here — they need semver-major bumps (
react-scriptseject-level upgrade,ag-grid-community29 → 36) and belong in separate PRs. Python backend (pip-audit -r traderx-monolith/requirements.txt) reports no known vulnerabilities.Link to Devin session: https://app.devin.ai/sessions/abd057b367af41d9936bb393e1e88a71
Open in Devin Desktop: https://app.devin.ai/desktop/session/abd057b367af41d9936bb393e1e88a71?variant=devin
Requested by: @mbatchelor81