Skip to content

fix(web): patch critical npm audit findings (shell-quote, websocket-driver) - #235

Open
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1788699766-npm-critical-audit-fixes
Open

devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1788699766-npm-critical-audit-fixes

Conversation

@devin-ai-integration

Copy link
Copy Markdown

Summary

npm audit in web-front-end/react reported 2 CRITICAL vulnerabilities, both transitive under react-scripts@5.0.1 (dev tooling, not shipped bundle code):

Since neither is a direct dependency and react-scripts is unmaintained, this adds npm overrides in package.json:

"overrides": {
  "shell-quote": "^1.10.0",
  "websocket-driver": "^0.7.5"
}

and regenerates package-lock.json. Result: 55 → 53 vulnerabilities (0 critical). tsc --noEmit and react-scripts build pass.

Backend (traderx-monolith/requirements.txt) had no pip-audit findings, so no Python changes.

Remaining 29 HIGH findings are mostly react-scripts internals (svgo/nth-check/postcss/workbox) that need a CRA replacement (e.g. Vite) to fully resolve; ws, socket.io-parser, underscore could be overridden the same way in a follow-up.

Link to Devin session: https://app.devin.ai/sessions/a5720ccd69d54858b890135bfcbfbd48
Open in Devin Desktop: https://app.devin.ai/desktop/session/a5720ccd69d54858b890135bfcbfbd48?variant=devin
Requested by: @mbatchelor81

… npm audit findings

Co-Authored-By: Mason <masonbatchelor81@gmail.com>
@devin-ai-integration

Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration

Copy link
Copy Markdown
Author

Completed local browser smoke testing for the npm overrides.

CRA/HMR and realtime smoke results
  • CRA compiled with shell-quote 1.10.0 and websocket-driver 0.7.5.
  • Header hot-update retained selected account state; original source restored.
  • Both development-server and Socket.io websocket handshakes returned 101; no SockJS/websocket errors.
  • AAPL Buy 7 appeared live as Settled, increasing trades 5→6.
Before HMR update without reload
Original header Hot-updated header
Pre-existing findings (unchanged UI code, not caused by this PR)

Position updates append a duplicate AAPL row (70 and 77), increasing position count 4→5. The trade form also emits React heading/key warnings. Baseline comparison against main was not performed.

Live trade and duplicate position

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant