Skip to content

fix(deps): patch critical shell-quote and websocket-driver CVEs in React frontend - #238

Open
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1788958952-bump-critical-npm-deps
Open

devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1788958952-bump-critical-npm-deps

Conversation

@devin-ai-integration

Copy link
Copy Markdown

Summary

npm audit on web-front-end/react reported 2 critical vulnerabilities, both transitive via react-scripts@5.0.1:

react-scripts is unmaintained, so the fix is an npm overrides block in package.json pinning both to patched ranges (shell-quote@^1.8.5 → resolves 1.10.0, websocket-driver@^0.7.5), with package-lock.json regenerated accordingly.

Result: npm audit criticals 2 → 0 (57 → 55 total). tsc --noEmit and npm run build pass. Remaining highs are mostly react-scripts internals (svgo/nth-check/postcss/serialize-javascript) that only resolve via a breaking react-scripts change, plus ag-grid-community (direct, upgrade to 36.x is a major bump) — left out of scope.

Backend (traderx-monolith/requirements.txt): pip-audit found 0 vulnerabilities (requirements are unpinned, so it resolves to current releases).

Link to Devin session: https://app.devin.ai/sessions/cf9ba4b3987d4587837d303aa920e33b
Open in Devin Desktop: https://app.devin.ai/desktop/session/cf9ba4b3987d4587837d303aa920e33b?variant=devin
Requested by: @mbatchelor81

…l CVEs

Co-Authored-By: Mason <masonbatchelor81@gmail.com>
@devin-ai-integration

Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration

Copy link
Copy Markdown
Author

Local dependency smoke test

Browser smoke assertions passed using Node 20 and the real local monolith:

  • Dev server compiled without errors (webpack compiled successfully).
  • Selecting account #22214 rendered 5 trades and 4 positions with the expected seeded values.
  • No browser websocket/HMR or runtime errors.
  • Dev /ws returned HTTP 101 and delivered hot, liveReload, hash, ok messages (exercises the overridden websocket-driver).

Verified trade and position grids

Transport evidence and coverage limits
Console Development websocket
No runtime errors HTTP 101 websocket handshake

Not exercised: source-edit hot reload, SockJS fallback, trade creation.

Written by Devin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant