fix(deps): patch critical shell-quote and websocket-driver CVEs in React frontend - #238
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…l CVEs Co-Authored-By: Mason <masonbatchelor81@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Author
Local dependency smoke testBrowser smoke assertions passed using Node 20 and the real local monolith:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm auditonweb-front-end/reactreported 2 critical vulnerabilities, both transitive viareact-scripts@5.0.1:shell-quote@1.8.3(viareact-dev-utils,launch-editor) — GHSA-w7jw-789q-3m8p (newline escaping), GHSA-395f-4hp3-45gv (quadratic DoS inparse())websocket-driver@0.7.4(viawebpack-dev-server→sockjs→faye-websocket) — GHSA-mp7j-qc5w-4988, GHSA-xv26-6w52-cph6react-scriptsis unmaintained, so the fix is an npmoverridesblock inpackage.jsonpinning both to patched ranges (shell-quote@^1.8.5→ resolves 1.10.0,websocket-driver@^0.7.5), withpackage-lock.jsonregenerated accordingly.Result:
npm auditcriticals 2 → 0 (57 → 55 total).tsc --noEmitandnpm run buildpass. Remaining highs are mostlyreact-scriptsinternals (svgo/nth-check/postcss/serialize-javascript) that only resolve via a breakingreact-scriptschange, plusag-grid-community(direct, upgrade to 36.x is a major bump) — left out of scope.Backend (
traderx-monolith/requirements.txt):pip-auditfound 0 vulnerabilities (requirements are unpinned, so it resolves to current releases).Link to Devin session: https://app.devin.ai/sessions/cf9ba4b3987d4587837d303aa920e33b
Open in Devin Desktop: https://app.devin.ai/desktop/session/cf9ba4b3987d4587837d303aa920e33b?variant=devin
Requested by: @mbatchelor81