Fix 2 critical npm audit findings via overrides (shell-quote, websocket-driver) - #242
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…indings Co-Authored-By: Mason <masonbatchelor81@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm auditinweb-front-end/reactreported 57 vulnerabilities, 2 of them critical. Both are transitive deps pulled in byreact-scripts@5.0.1(no direct dep to bump), so this adds npmoverridesinpackage.jsonto force patched versions:Result:
npm auditcritical count 2 -> 0 (57 -> 55 total). Both packages are dev-server/tooling deps; runtime bundle is unaffected.tsc --noEmitandCI=true npm run buildpass.Remaining 29 high findings are mostly rooted in
react-scripts@5.0.1(webpack 5 toolchain) andag-grid-community@29and would need major upgrades — left for follow-up (see audit report in the session).Backend (
traderx-monolith/requirements.txt):pip-auditfound 0 known vulnerabilities.Link to Devin session: https://app.devin.ai/sessions/adf1be716dd24959bac9db728660e77f
Open in Devin Desktop: https://app.devin.ai/desktop/session/adf1be716dd24959bac9db728660e77f?variant=devin
Requested by: @mbatchelor81