Pin shell-quote and websocket-driver to fix critical npm audit findings - #245
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…cal npm audit findings Co-Authored-By: Mason <masonbatchelor81@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm auditinweb-front-end/reactreported 2 CRITICAL transitive vulnerabilities, both pulled in viareact-scripts@5.0.1(webpack-dev-server / sockjs):shell-quote@1.8.3— GHSA-w7jw-789q-3m8p, GHSA-395f-4hp3-45gvwebsocket-driver@0.7.4— GHSA-mp7j-qc5w-4988, GHSA-xv26-6w52-cph6Fixed via npm
overrides(noreact-scriptsupgrade, no--force):(
1.9.0is the lowest publishedshell-quoteabove the vulnerable<=1.8.4range.)Result:
57 vulnerabilities (… 2 critical)→55 vulnerabilities (12 low, 14 moderate, 29 high, 0 critical);CI=false npm run buildpasses. Remaining HIGH findings are almost entirely inside thereact-scriptstoolchain and require a breaking upgrade (npm audit fix --forcewould installreact-scripts@0.0.0), so they're left for a separate change.Link to Devin session: https://app.devin.ai/sessions/20628b24798c41639f0269c1de489bbe
Open in Devin Desktop: https://app.devin.ai/desktop/session/20628b24798c41639f0269c1de489bbe?variant=devin
Requested by: @mbatchelor81