Center characters vertically #234
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently math challenges look a bit weird because the math operators are smaller than the numbers and everything is aligned at the top of the image. This change moves all characters to the vertical center, making math challenges a bit nicer to look at.
|
Well, one could argue that having a slightly unaligned vertical offset would make OCRing the generated image a bit harder and thus the CAPTCHA more effective, don't you think? I.e. the goal is not to have a pleasing outcome. |
|
Hmm yes, I can see that. Feel free to close/ignore this then. |
|
Closing, thank you for the PR though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently math challenges look a bit weird because the math operators are smaller than the numbers and everything is aligned at the top of the image.
This change moves all characters to the vertical center, making math challenges a bit nicer to look at.
Before:
After:
