feat: speed up playwright with prebuilt image#1050
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR accelerates end-to-end tests by switching the GitHub Actions runner to a prebuilt Playwright container and simplifying dependency caching.
- Uses the
mcr.microsoft.com/playwright:v1.52.0-noblecontainer with non-root user for tests - Replaces manual pnpm store caching with
cache: 'pnpm'inactions/setup-node@v4 - Removes explicit Playwright browser installation step, relying on the container’s prebuilt binaries
Comments suppressed due to low confidence (2)
.github/workflows/test-e2e.yml:37
- Use
pnpm install --frozen-lockfile(orpnpm ci) to ensure the lockfile is strictly honored and prevent unintended dependency updates during CI runs.
run: pnpm install
.github/workflows/test-e2e.yml:39
- The
playwright install --with-depsstep was removed—confirm thatmcr.microsoft.com/playwright:v1.52.0-nobleincludes all required browser binaries and dependencies, or re-add the install step to avoid test failures.
- name: Run Playwright tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.