Potential fix for code scanning alert no. 10: Workflow does not contain permissions#1069
Merged
Conversation
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/mbifulco/blog/security/code-scanning/10
To address this, add a
permissionskey to either the root of the workflow or specifically to theplaywrightjob (since only one job exists, the effect is the same). The minimal and safest explicit setting ispermissions: contents: read, which gives the steps access to the repository code without additional write capabilities. This should be added directly after the workflownameat the root, or after theplaywrightjob name. Since there is only one job, adding it at the workflow level is clearer, easier to audit, and covers any future jobs as well.Suggested fixes powered by Copilot Autofix. Review carefully before merging.