Skip to content

Blacklist apexgunparts.space for newsletter subscriptions#1267

Merged
mbifulco merged 1 commit into
mainfrom
copilot/add-apexgunparts-space-to-blacklist
Jun 13, 2026
Merged

Blacklist apexgunparts.space for newsletter subscriptions#1267
mbifulco merged 1 commit into
mainfrom
copilot/add-apexgunparts-space-to-blacklist

Conversation

Copilot AI commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Spam signups were coming from apexgunparts.space, which was not covered by existing domain-based filtering. This PR extends the newsletter spam-domain blacklist to block that domain consistently across subscription paths.

  • Blacklist update

    • Added apexgunparts.space to the centralized BAD_DOMAINS list used by newsletter subscription filtering.
  • Behavior coverage

    • Extended unit coverage to assert this domain is treated as spam by:
      • emailIsBad(...)
      • fakeSubscribe(...)
      • subscribe(...) (returns the same fake-success response used for blocked domains)
const BAD_DOMAINS = ['mailinator.com', 'abhoward.site', 'apexgunparts.space'];

@vercel

vercel Bot commented Jun 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
mikebifulco-com-bnbu Ready Ready Preview, Comment Jun 13, 2026 12:17pm

@mbifulco mbifulco marked this pull request as ready for review June 13, 2026 12:23
Copilot AI review requested due to automatic review settings June 13, 2026 12:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the newsletter anti-spam domain filtering to consistently treat apexgunparts.space as a blocked domain, ensuring blocked-domain behavior is applied across all subscription paths that rely on emailIsBad(...).

Changes:

  • Added apexgunparts.space to the centralized BAD_DOMAINS blacklist.
  • Added unit tests to verify emailIsBad(...) flags the new domain.
  • Added unit tests to verify fakeSubscribe(...) and subscribe(...) return the existing “fake success” responses for the new blocked domain.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/utils/resend.ts Adds apexgunparts.space to the shared newsletter spam-domain blacklist.
src/utils/resend.test.ts Extends unit tests to cover the new blocked domain across emailIsBad, fakeSubscribe, and subscribe.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mbifulco mbifulco merged commit 20dc74c into main Jun 13, 2026
9 checks passed
@mbifulco mbifulco deleted the copilot/add-apexgunparts-space-to-blacklist branch June 13, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants