Block integer local-part emails in emailIsBad#1268
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Copilot
AI
changed the title
Update emailIsBad to block integer local-part emails
Block integer local-part emails in Jun 13, 2026
emailIsBad
Copilot created this pull request from a session on behalf of
mbifulco
June 13, 2026 19:28
View session
mbifulco
approved these changes
Jun 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates newsletter subscription anti-abuse logic by expanding emailIsBad to also flag emails whose local-part is integer-only, and extends unit test coverage to ensure fakeSubscribe/subscribe treat those addresses as “bad” inputs.
Changes:
- Extended
emailIsBadto returntruewhen the local-part is composed only of digits. - Added unit test coverage for integer-only local parts in
emailIsBad,fakeSubscribe, andsubscribe.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/utils/resend.ts |
Updates emailIsBad filtering logic to include integer-only local parts. |
src/utils/resend.test.ts |
Adds tests asserting integer-only local parts are treated as “bad” for filtering and subscription flows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+241
to
+244
| const localPart = email.split('@')[0]; | ||
| const domain = email.split('@')[1]?.toLowerCase(); | ||
| return BAD_DOMAINS.includes(domain); | ||
| const hasIntegerLocalPart = /^\d+$/.test(localPart); | ||
| return BAD_DOMAINS.includes(domain) || hasIntegerLocalPart; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
emailIsBadpreviously filtered only by blocked domains, allowing addresses like123@domain.comthrough. This update extends the check to also treat integer-only local parts as bad inputs.Email filtering logic
emailIsBad.Coverage updates
emailIsBadfakeSubscribesubscribeBehavior example