Fix High and Medium Severity level coverity findings#130
Open
ErnoKilp wants to merge 11 commits into
Open
Conversation
CWE-78(OS Commadn injection (https://cwe.mitre.org/data/definitions/78.html)
CWE-119 (Out-of-bounds access) (https://cwe.mitre.org/data/definitions/119.html)
CWE-404 (Resource leak) (https://cwe.mitre.org/data/definitions/404.html)
CWE-369 (Division or modulo by float zero) (https://cwe.mitre.org/data/definitions/369.html)
CWE-369 (Division or modulo by float zero) (https://cwe.mitre.org/data/definitions/369.html)
CWE-369 (Division or modulo by float zero) (https://cwe.mitre.org/data/definitions/369.html)
CWE-252 (Ignoring number of bytes read) (https://cwe.mitre.org/data/definitions/252.html)
CWE-252 (Ignoring number of bytes read) (https://cwe.mitre.org/data/definitions/252.html)
CWE-252 (Ignoring number of bytes read ) (https://cwe.mitre.org/data/definitions/252.html)
CWE-252 (Ignoring number of bytes read) (https://cwe.mitre.org/data/definitions/252.html)
CWE-563 (Unused value) (https://cwe.mitre.org/data/definitions/563.html)
Owner
|
I'm conflicted. There is no reasonable person that expects test code and example code to be bullet-proof. However, these diffs do actually seem worthwhile in the scenario where someone might simply copy and paste that code into their project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scanned latest master with BlackDuck Codesight Coverity scanning tool and fix High and Medium severity level findings.