Support moving API key out of configuration variable - #35
Draft
lemald wants to merge 5 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asana ticket: part of 🔮 Build out a way to measure RTR uptime
Note that I used Copilot for most of these changes, but made some manual edits and tweaks myself.
This change introduces a new way for the configuration to specify which URL the application should query for each of its checks. Rather than having each check in the JSON specify the full URL, we can now specify a relative path. Then, the path is combined with the base URL from the
BASE_URLenvironment variable. The idea here is that each API checker environment will only be querying on v3 API environment, so this reduces redundancy in the configuration itself. Finally, for the API key itself, we reference the newAPI_KEYenvironment variable and append it as a separate query parameter to the full URL, specifically in cases where thepathis specified. All of the existing functionality to specify the fullurlvalue in the check is maintained (for now), so this will be backwards-compatible with the old configuration.