Skip to content

[Perf]: Optimize news entry rendering #3450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lvachon1 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Perf]: Optimize news entry rendering #3450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea4ea83
I attempted to optimize HTML rendering without caches but date format…
lvachon1 Aug 26, 2026
d4de32f
Included a locale in the test's assigns for this function
lvachon1 Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/dotcom_web/views/page_view.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,13 @@ defmodule DotcomWeb.PageView do
content_tag(:span, "|", aria_hidden: "true", class: "schedule-separator")
end

@decorate cacheable(
cache: @cache,
on_error: :raise,
opts: [ttl: @ttl],
# Even though the text isn't translated, the dates are so locale is part of the key
key: {"homepage|news-entries", conn.assigns.locale}
)
@spec render_news_entries(Plug.Conn.t()) :: Phoenix.HTML.Safe.t()
def render_news_entries(conn) do
content_tag(
Expand Down
1 change: 1 addition & 0 deletions test/dotcom_web/views/page_view_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ defmodule DotcomWeb.PageViewTest do
document =
conn
|> assign(:news, entries)
|> assign(:locale, "en-US")
|> PageView.render_news_entries()
|> Phoenix.HTML.Safe.to_iodata()
|> IO.iodata_to_binary()
Expand Down
Loading