Skip to content

[LineDiagram] : Inline Metro Map into Dotcom - #3464

Merged
lvachon1 merged 8 commits into
mainfrom
lev/feat/metro_map
Sep 1, 2026
Merged

[LineDiagram] : Inline Metro Map into Dotcom#3464
lvachon1 merged 8 commits into
mainfrom
lev/feat/metro_map

Conversation

@lvachon1

@lvachon1 lvachon1 commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Scope

Asana Ticket: 🛠️💈 Inline Metro Map into Dotcom

Implementation

Moved the live component over
Moved the JS hook over
Moved the CSS over
Moved the maplibre-gl dependency over

Removed the map from metro

Rational: Anticipating that we will need to update and enhance this map, it was decided that it would be easier to work on as a Dotcom component than as a Metro component.

Thoughts: Should we update our maplibre-gl version?

Screenshots

No visual difference!

How to test

http://localhost:4001/trip-planner - Confirm that the map still works (markers, lines, zoom, pan, rotate)
http://localhost:4001/preview/stop-map - This too why not

@lvachon1
lvachon1 marked this pull request as ready for review September 1, 2026 18:35
@lvachon1
lvachon1 requested a review from a team as a code owner September 1, 2026 18:35
@lvachon1
lvachon1 requested a review from joshlarson September 1, 2026 18:35

@joshlarson joshlarson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woop!

Comment thread assets/css/map.css Outdated
Comment thread lib/dotcom_web/components/map.ex Outdated
@lvachon1
lvachon1 merged commit 50732cd into main Sep 1, 2026
20 checks passed
@lvachon1
lvachon1 deleted the lev/feat/metro_map branch September 1, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants