feat: Style tweaks for the route schedule page headers - #3477
Draft
joshlarson wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: 💈 Visual styling tweaks
Implementation
I did this in three commits:
<h1>{route_header_text}</h1>, but I imagine that we may want to eventually use it for the whole schedule route header.Screenshots
Subway
Commuter Rail
Silver Line Bus
Non-Silver Line Bus
Ferry
How to test
Look at the various route pages linked above, as well as any other route pages you can think of.
Note
I'm not sure I love the wrapping behavior for bus routes with long names. It's not new, but the combination of the bottom-padding change and the fact that the bus route ID and the route description are the same font size now make the wrapping look more wrong (IMO). I'm interested in ideas for how to make that look better, and will likely explore those before merging.