Skip to content

fix: add more specific DELTA partition for lamp ingestion, - #790

Open
huangh wants to merge 3 commits into
hh-ingestion-refactor-newfrom
hh-fix-ingestion-only-from-delta-partition
Open

fix: add more specific DELTA partition for lamp ingestion,#790
huangh wants to merge 3 commits into
hh-ingestion-refactor-newfrom
hh-fix-ingestion-only-from-delta-partition

Conversation

@huangh

@huangh huangh commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

original assumptions were that the only partition in incoming was incoming/lamp/delta, but now there is incoming/lamp/railds which breaks our original assumption. specify delta for lamp ingestion pipeline.

@huangh
huangh requested a review from a team as a code owner August 12, 2026 16:04
@huangh
huangh requested a review from runkelcorey August 12, 2026 16:04
@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown

LCOV of commit abecbd9 during Continuous Integration (Python) #2051

Summary coverage rate:
  lines......: 64.3% (3653 of 5681 lines)
  functions..: 29.7% (279 of 940 functions)
  branches...: no data found

Files changed coverage rate:
                                                                                     |Lines       |Functions  |Branches    
  Filename                                                                           |Rate     Num|Rate    Num|Rate     Num
  =========================================================================================================================
  src/lamp_py/ingestion/ingest_gtfs.py                                               | 0.0%     63| 0.0%    10|    -      0
  src/lamp_py/ingestion/pipeline.py                                                  | 0.0%     38| 0.0%     4|    -      0
  src/lamp_py/runtime_utils/remote_files.py                                          | 100%     79|50.0%     6|    -      0

runkelcorey
runkelcorey previously approved these changes Aug 12, 2026
View reviewed changes

@runkelcorey runkelcorey left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev deployment will validate this

@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown

LCOV of commit eb0b6aa during Continuous Integration (Python) #2052

Summary coverage rate:
  lines......: 64.1% (3645 of 5682 lines)
  functions..: 29.7% (279 of 940 functions)
  branches...: no data found

Files changed coverage rate:
                                                                                     |Lines       |Functions  |Branches    
  Filename                                                                           |Rate     Num|Rate    Num|Rate     Num
  =========================================================================================================================
  src/lamp_py/ingestion/convert_gtfs_rt_fullset.py                                   |43.3%     97|14.3%    14|    -      0
  src/lamp_py/ingestion/ingest_gtfs.py                                               | 0.0%     63| 0.0%    10|    -      0
  src/lamp_py/ingestion/pipeline.py                                                  | 0.0%     38| 0.0%     4|    -      0
  src/lamp_py/runtime_utils/remote_files.py                                          | 100%     79|50.0%     6|    -      0

@huangh
huangh force-pushed the hh-fix-ingestion-only-from-delta-partition branch from eb0b6aa to 8f84f80 Compare August 14, 2026 18:15
@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown

LCOV of commit 8f84f80 during Continuous Integration (Python) #2056

Summary coverage rate:
  lines......: 64.3% (3653 of 5683 lines)
  functions..: 29.7% (279 of 940 functions)
  branches...: no data found

Files changed coverage rate:
                                                                                     |Lines       |Functions  |Branches    
  Filename                                                                           |Rate     Num|Rate    Num|Rate     Num
  =========================================================================================================================
  src/lamp_py/ingestion/convert_gtfs_rt_fullset.py                                   |43.3%     97|14.3%    14|    -      0
  src/lamp_py/ingestion/ingest_gtfs.py                                               | 0.0%     63| 0.0%    10|    -      0
  src/lamp_py/ingestion/pipeline.py                                                  | 0.0%     38| 0.0%     4|    -      0
  src/lamp_py/runtime_utils/remote_files.py                                          | 100%     79|50.0%     6|    -      0

@huangh
huangh force-pushed the hh-fix-ingestion-only-from-delta-partition branch from 8f84f80 to dac57dc Compare August 14, 2026 21:08
@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown

LCOV of commit dac57dc during Continuous Integration (Python) #2062

Summary coverage rate:
  lines......: 64.2% (3653 of 5687 lines)
  functions..: 29.6% (279 of 942 functions)
  branches...: no data found

Files changed coverage rate:
                                                                                     |Lines       |Functions  |Branches    
  Filename                                                                           |Rate     Num|Rate    Num|Rate     Num
  =========================================================================================================================
  src/lamp_py/ingestion/convert_gtfs_rt_fullset.py                                   |43.3%     97|14.3%    14|    -      0
  src/lamp_py/ingestion/ingest_gtfs.py                                               | 0.0%     63| 0.0%    10|    -      0
  src/lamp_py/ingestion/pipeline.py                                                  | 0.0%     38| 0.0%     4|    -      0
  src/lamp_py/runtime_utils/remote_files.py                                          | 100%     79|50.0%     6|    -      0

@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown

LCOV of commit 489f2d6 during Continuous Integration (Python) #2064

Summary coverage rate:
  lines......: 64.2% (3653 of 5687 lines)
  functions..: 29.6% (279 of 942 functions)
  branches...: no data found

Files changed coverage rate:
                                                                                     |Lines       |Functions  |Branches    
  Filename                                                                           |Rate     Num|Rate    Num|Rate     Num
  =========================================================================================================================
  src/lamp_py/ingestion/convert_gtfs_rt_fullset.py                                   |43.3%     97|14.3%    14|    -      0
  src/lamp_py/ingestion/ingest_gtfs.py                                               | 0.0%     63| 0.0%    10|    -      0
  src/lamp_py/ingestion/pipeline.py                                                  | 0.0%     38| 0.0%     4|    -      0
  src/lamp_py/runtime_utils/remote_files.py                                          | 100%     79|50.0%     6|    -      0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@runkelcorey runkelcorey runkelcorey left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@huangh @runkelcorey