perf(cache): stable cache keys and graceful shutdown fix #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use JSON.stringify with replacer for stable key ordering
This preserves JSON.stringify semantics (Date.toJSON, undefined omission,
etc.) while ensuring {a:1, b:2} and {b:2, a:1} produce the same cache key
- Call unref() on cleanup interval so it doesn't prevent graceful shutdown
Without this, the hourly interval keeps the Node.js event loop alive
even when the server is trying to shut down
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>
mbuckingham74
force-pushed
the
perf/cache-key-stability
branch
from
c7a068e to
25025a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Two cache service improvements:
1. Stable cache key generation
The old code used raw
JSON.stringify(params)which produces different strings for objects with the same properties but different key order:This could cause duplicate cache entries for logically identical requests, wasting storage and causing cache misses.
The new
stableStringify()function sorts object keys before stringifying, ensuring consistent cache keys.2. Cleanup interval graceful shutdown
Added
.unref()call to the hourly cleanup interval. Without this, the interval keeps the Node.js event loop alive and prevents graceful process shutdown.Test plan
🤖 Generated with Claude Code