Skip to content

Conversation

@IsaacGemal
Copy link
Contributor

Low hanging fruit PR - just some simple quality of life tweaks for local setup and build times.
UV to make docker compile times a bit quicker (we're not using UV for the env, just literally to replace pip).
Give it a shot, it's a nice upgrade and it doesn't impact anything else.
Adding the minio creation in the docker yml because a person shouldn't have to know to run this very specific command from make reset to get the entire setup running.

	docker-compose exec object sh -c "mc alias set object http://localhost:9000 fake_key fake_secret && \
		mc mb object/mcbench-backend-object-local && mc anonymous set download object/mcbench-backend-object-local && \
		mc mb object/mcbench-object-cdn-local && mc anonymous set download object/mcbench-object-cdn-local"

And of course tweaking the seed script.

I think this is all fine except maybe the deps-builders dockerfile.

This is my initial attempt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants