Skip to content

Conversation

@Bankso
Copy link
Contributor

@Bankso Bankso commented Oct 18, 2024

Fixes #116

Once merging, we should wait to create a release until 1) models have been reviewed internally and 2) data model explorer documentation has been updated

Changelog

This PR integrates several new metadata attributes, valid values, and models. Most attributes and valid values were adapted from those used in CDS/CRDC and HTAN models. The attributes were renamed, if necessary for clarity, and assembled into a set of models intended to capture file information and experimental details. CDS/CRDC source materials are available here:

Note: Attribute mappings in these sheets are being converted to a formal reference document that will be integrated into the data-models repository

Guidance on working with the updated data model is in preparation here, alongside info on all other resource management infrastructure elements.

The model expansion and redesign also includes an updated information linking framework, which employs primary ("component_id") and foreign keys ("component Key") to define connections between records and/or files. Information on the _id/Key system is contained in Appendices of the guidance doc linked above.

Updated templates are available in the repo as CSVs. Google sheet links for review:

Record manifests

File manifests

Imaging manifests

Nanostring GeoMx manifests

Sequencing manifests

10x Visium manifests

Bankso added 30 commits July 25, 2024 15:43
Removed Publication, Publication View DCA and PublicationViewDCA_id
- add initial foreign key attributes to PublicationView
- remove unused attributes
- add initial foreign key attributes to ProjectView
- remove unused attributes
- add initial foreign key attributes to PersonView
- add initial foreign key attributes to DatasetView
Channel Metal Isotope Element should be Channel Metal Symbol in mapping.yml. Also removed the incorrect attribute appended to imagingChannel/annotationProperty.csv when building model with incorrect mapping.yml
Bump schematicpy to 24.10.2
via schematic 24.10.2
@Bankso Bankso marked this pull request as ready for review October 25, 2024 00:53
@Bankso Bankso requested a review from vpchung as a code owner October 25, 2024 00:53
Bankso added 15 commits October 25, 2024 15:10
Add additional templates to datatypes and add an if statement to control make. Model conversion is taking ~13-15 minutes, so we only want to run that when necessary.
Schemas can be bound to entities in Synapse via the client
Testing schema binding and Synapse suggests maxItems element is not supported
Sequencing Level 1 - 3 will serve as a broad sequencing assay template. Sub models will be added that contain more specific information types.

SequencingRNALevel1 will surface RNA-seq focused metadata elements for raw/unprocessed data
Move NGS RNA term mappings into sequencingRNALevel1 section
- remove redundant attributes already captured in File View metadata (File Format, Biospecimen Key)
- update names for Visium and RNA-seq related attributes
- remove redundant attributes already captured in File View metadata (File Format, Biospecimen Key)
- update names for Visium and RNA-seq related attributes
- remove redundant attributes already captured in File View metadata (File Format, Biospecimen Key)
- update names for Visium and RNA-seq related attributes
- remove redundant attributes already captured in File View metadata (File Format, Biospecimen Key)
- update names for Visium related attributes
Add SequencingRNALevel1 Key
Schematic v24.10.2
@Bankso Bankso merged commit b3ff791 into main Oct 31, 2024
1 check passed
@Bankso Bankso deleted the refactor-add-cds-imaging branch October 31, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

major PR label for a major update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integration/mapping to existing CDS templates

3 participants