-
Couldn't load subscription status.
- Fork 1
Refactor add cds imaging #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed Publication, Publication View DCA and PublicationViewDCA_id
- add initial foreign key attributes to PublicationView - remove unused attributes
- add initial foreign key attributes to ProjectView - remove unused attributes
- add initial foreign key attributes to PersonView
- add initial foreign key attributes to DatasetView
Channel Metal Isotope Element should be Channel Metal Symbol in mapping.yml. Also removed the incorrect attribute appended to imagingChannel/annotationProperty.csv when building model with incorrect mapping.yml
Bump schematicpy to 24.10.2
via schematic 24.10.2
Add additional templates to datatypes and add an if statement to control make. Model conversion is taking ~13-15 minutes, so we only want to run that when necessary.
Schemas can be bound to entities in Synapse via the client
Testing schema binding and Synapse suggests maxItems element is not supported
Sequencing Level 1 - 3 will serve as a broad sequencing assay template. Sub models will be added that contain more specific information types. SequencingRNALevel1 will surface RNA-seq focused metadata elements for raw/unprocessed data
Move NGS RNA term mappings into sequencingRNALevel1 section
- remove redundant attributes already captured in File View metadata (File Format, Biospecimen Key) - update names for Visium and RNA-seq related attributes
- remove redundant attributes already captured in File View metadata (File Format, Biospecimen Key) - update names for Visium and RNA-seq related attributes
- remove redundant attributes already captured in File View metadata (File Format, Biospecimen Key) - update names for Visium and RNA-seq related attributes
- remove redundant attributes already captured in File View metadata (File Format, Biospecimen Key) - update names for Visium related attributes
Add SequencingRNALevel1 Key
Schematic v24.10.2
aditigopalan
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #116
Once merging, we should wait to create a release until 1) models have been reviewed internally and 2) data model explorer documentation has been updated
Changelog
This PR integrates several new metadata attributes, valid values, and models. Most attributes and valid values were adapted from those used in CDS/CRDC and HTAN models. The attributes were renamed, if necessary for clarity, and assembled into a set of models intended to capture file information and experimental details. CDS/CRDC source materials are available here:
Note: Attribute mappings in these sheets are being converted to a formal reference document that will be integrated into the data-models repository
Guidance on working with the updated data model is in preparation here, alongside info on all other resource management infrastructure elements.
The model expansion and redesign also includes an updated information linking framework, which employs primary ("component_id") and foreign keys ("component Key") to define connections between records and/or files. Information on the _id/Key system is contained in Appendices of the guidance doc linked above.
Updated templates are available in the repo as CSVs. Google sheet links for review:
Record manifests
File manifests
Imaging manifests
Nanostring GeoMx manifests
Sequencing manifests
10x Visium manifests