Skip to content

Run Rust CI on macOS and scope workflow token permissions - #1

Merged
mcaney006 merged 3 commits into
mainfrom
copilot/fix-github-actions-build-job
Aug 29, 2026
Merged

Run Rust CI on macOS and scope workflow token permissions#1
mcaney006 merged 3 commits into
mainfrom
copilot/fix-github-actions-build-job

Conversation

Copilot AI commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

The failing build Actions job was running the desktop app on ubuntu-latest, where linking failed on Linux-only system dependencies (xcb/xkbcommon). This change aligns CI with the app’s actual platform target and tightens the workflow token scope.

  • CI platform

    • Run the build job on macos-latest instead of ubuntu-latest
    • Keep the existing cargo build / cargo test flow unchanged
  • Workflow hardening

    • Add explicit GITHUB_TOKEN permissions for the job
    • Limit access to the minimum needed: contents: read
  • Result

    • The workflow now executes on the supported GPUI/AppKit/Metal platform instead of failing during Linux linking
jobs:
  build:
    permissions:
      contents: read
    runs-on: macos-latest

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@mcaney006
mcaney006 marked this pull request as ready for review August 29, 2026 23:20
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 29, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-29T23:21:49.000459Z a6bc7c6 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI and others added 2 commits August 29, 2026 23:20
Co-authored-by: mcaney006 <254775535+mcaney006@users.noreply.github.com>
Co-authored-by: mcaney006 <254775535+mcaney006@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job 'build' Run Rust CI on macOS and scope workflow token permissions Aug 29, 2026
Copilot AI requested a review from mcaney006 August 29, 2026 23:23
@mcaney006
mcaney006 merged commit 74afd5b into main Aug 29, 2026
2 checks passed
@mcaney006
mcaney006 deleted the copilot/fix-github-actions-build-job branch August 29, 2026 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants