test: widen snapshot fuzz to 2% for cross-arch AA#49
Merged
Conversation
mcanouil
added
the
Type: CI/CD 🤖
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snapshot goldens generated on one CPU architecture could fail CI on another: arm64 and x86_64 differ in floating-point rounding, nudging anti-aliased edges by a sub-pixel. With
tolerance: 0/fuzz: 1%that surfaced as AE=1 boundary failures on a handful of anti-aliasing-sensitive examples (e.g. thegeom-smoothband), even though the renders agree visually.--fuzzfrom 1% to 2% intools/snapshot/run.lua.tolerancestays0: still no stray pixels allowed; only the per-pixel colour threshold widens, which absorbs cross-architecture AA while structural changes (a mark moving onto a different background) still fail.