9767 inbound 13 - #66
Open
RHODOK wants to merge 7 commits into
Open
Conversation
This test executes a document with a patch that causes failure in order to test the rollback functionality.
Clearing the cache and fields that need to be recalculated after a failure rollback will prevent further failures from recalculations or accessing cached objects
Recent changes to fix issues with comparators has introduced a
new edge case. Two identical values may be evaluated as different
when part of them (while being the same value) needs to be
constructed as another new record. Example: partner title record
has not yet been constructed and the same partner is attempted to
be created twice, this results in the partner being identified as
different causing an attempt at creating the parnter twice, the
unique constraint for a partner then causes the creation of a
partner to be invalidated.
Signed-off-by: Robert Smith <robert.smith@unipart.io>
When a partner is created and no title of the type already exists a models.NewId is used, this causes the same person ingested twice to be incorrectly treated as separate entities. Signed-off-by: Robert Smith <robert.smith@unipart.io>
User-story: 9767 Signed-off-by: Robert Smith <robert.smith@unipart.io>
User-story: 9767 Signed-off-by: Robert Smith <robert.smith@unipart.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.