Skip to content

Fix #1: add support to read from Catena FRAM#2

Open
dhineshkumarmcci wants to merge 13 commits intomasterfrom
issue1
Open

Fix #1: add support to read from Catena FRAM#2
dhineshkumarmcci wants to merge 13 commits intomasterfrom
issue1

Conversation

@dhineshkumarmcci
Copy link
Copy Markdown

No description provided.

@disk91
Copy link
Copy Markdown
Collaborator

disk91 commented Feb 23, 2021

looks good from helicopter view.
Just a remark on Key Management. It would be nice to encrypt the Sigfox key if not, at least, you should have no API for the end user to read it. This is a secret you should only write ; only the internal sigfox driver needs to access it.

@dhineshkumarmcci
Copy link
Copy Markdown
Author

hi Paul, thanks for the review. I will make the necessary changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants