Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project’s SDK version and refreshes test and benchmarking dependencies to their latest releases.
- Upgrades .NET SDK to 9.0.0 and disables prerelease usage in
global.json - Bumps test framework packages (
Microsoft.NET.Test.Sdk,xunit.runner.visualstudio,FsCheck,FsCheck.Xunit) - Updates benchmarking tools (
BenchmarkDotNet,BenchmarkDotNet.Diagnostics.Windows) and alignsFSharp.Coreversions
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/CsBenc.Tests/CsBenc.Tests.csproj | Bumped Microsoft.NET.Test.Sdk to 17.14.1 and xunit.runner.visualstudio to 3.1.2 |
| test/CsBenc.Check/CsBenc.Check.fsproj | Updated FsCheck, FsCheck.Xunit to 3.3.0, test SDK to 17.14.1, runner to 3.1.2, and FSharp.Core to 9.0.300 |
| global.json | Upgraded SDK version to 9.0.0 and set allowPrerelease to false |
| benchmarks/CsBenc.Benchmarks/CsBenc.Benchmarks.fsproj | Upgraded BenchmarkDotNet packages to 0.15.2 and FSharp.Core to 9.0.300 |
Comments suppressed due to low confidence (1)
global.json:3
- Consider updating project documentation (e.g., README or CONTRIBUTING) to indicate that .NET SDK 9.0.0 is now required and that prerelease builds are disabled so contributors and CI pipelines can install the correct SDK version.
"version": "9.0.0",
chore: Update build stack
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.