Skip to content

ACAS-928: Cover additional special characters in search test#183

Merged
bffrost merged 4 commits into
release/2026.2.xfrom
ACAS-928
Apr 1, 2026
Merged

ACAS-928: Cover additional special characters in search test#183
bffrost merged 4 commits into
release/2026.2.xfrom
ACAS-928

Conversation

@bffrost

@bffrost bffrost commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

Description

Original fix missed some locations which caused certain special characters to not work. Added a test that covers them to confirm the fix.

Related Issue

How Has This Been Tested?

(.venv) ➜  acasclient git:(release/2026.2.x) ✗ python -m unittest -v tests.test_acasclient.TestAcasclient.test_057_get_protocol_expt_special_characters_in_names
test_057_get_protocol_expt_special_characters_in_names (tests.test_acasclient.TestAcasclient)
Test getting protocols and experiments with special characters in their names. ... ok
Successfully deleted all experiments
Successfully deleted all cmpdreg bulk load files
Successfully deleted all salts
Successfully deleted all projects (except Global)

----------------------------------------------------------------------
Ran 1 test in 5.548s

OK

@bffrost bffrost mentioned this pull request Mar 25, 2026
Merged
@bffrost
bffrost requested a review from brianbolt March 25, 2026 17:00
brianbolt
brianbolt requested changes Mar 26, 2026
View reviewed changes

@brianbolt brianbolt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread tests/test_acasclient.py Outdated
@bffrost
bffrost changed the base branch from main to release/2026.2.x March 26, 2026 21:02
@bffrost
bffrost requested a review from brianbolt March 26, 2026 22:40
brianbolt
brianbolt requested changes Mar 27, 2026
View reviewed changes
Comment thread tests/test_acasclient.py Outdated
@bffrost
bffrost requested a review from brianbolt April 1, 2026 20:56
brianbolt
brianbolt approved these changes Apr 1, 2026
View reviewed changes

@brianbolt brianbolt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM

@bffrost
bffrost merged commit 500124e into release/2026.2.x Apr 1, 2026
3 checks passed
@bffrost
bffrost deleted the ACAS-928 branch April 1, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianbolt brianbolt brianbolt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bffrost @brianbolt