Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(warnings): avoid MissingSpecAttributeWarning if property type is missing or optional #258

Merged
merged 10 commits into from
Mar 19, 2025

Conversation

mcous
Copy link
Owner

@mcous mcous commented Mar 19, 2025

Fixes #257

@mcous mcous changed the title fix(warnings): do not trigger MissingSpecAttributeWarnings when property return is missing or optional fix(warnings): avoid MissingSpecAttributeWarning if property type is missing or optional Mar 19, 2025
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.41%. Comparing base (1654d65) to head (3c1bb28).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #258      +/-   ##
==========================================
+ Coverage   98.38%   98.41%   +0.02%     
==========================================
  Files          19       19              
  Lines         744      757      +13     
  Branches       90       93       +3     
==========================================
+ Hits          732      745      +13     
  Misses         10       10              
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mcous mcous merged commit 89cfeb0 into main Mar 19, 2025
42 checks passed
@mcous mcous deleted the property-false-warning branch March 19, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore some warnings and/or fix issue with @property
1 participant