fix: support functools.cached_property#335
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #335 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 32 32
Lines 1543 1548 +5
Branches 191 194 +3
=========================================
+ Hits 1543 1548 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughSummary by CodeRabbit
Walkthroughget_child_spec stops using inspect.unwrap and branches on raw descriptor types: handles Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/legacy/test_mock.py`:
- Around line 344-358: Fix the docstring typo in the test_cached_property test:
replace "It can mock a cached property classes." with a correct phrase such as
"It can mock cached properties." Locate the test function named
test_cached_property (and the inner class _Spec) and update its triple-quoted
docstring accordingly to remove the grammatical error.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: b50738ed-96df-4856-91cd-1d1fe2373903
📒 Files selected for processing (4)
decoy/next/_internal/inspect.pydecoy/spy_core.pytests/legacy/test_mock.pytests/test_mock.py
c233c9b to
18cf22f
Compare
18cf22f to
c5326fd
Compare
Summary by CodeRabbit
Bug Fixes
Tests