linting - #13
Merged
Merged
Conversation
Check json.Unmarshal/Decode/Put errors in tests, make ignored errors on cleanup paths explicit with _ =, check the seed file Close error in signer.WriteSeed, drop a dead jws assignment and an unneeded conversion, and regroup imports so local packages form their own group (goimports local-prefixes).
Enable errcheck, gosec, misspell, unconvert, and ineffassign plus the gofmt/goimports formatters; staticcheck and unused stay off until golangci-lint ships staticcheck 2026.2+, whose current IR builder panics on the Go 1.27 standard library. Noisy gosec rules (G115 integer conversions in tlog index math, operator-supplied path/URL taint rules, public-data file modes) are excluded with justifications in .golangci.yml. golangci-lint release binaries are built with released Go and cannot type-check a `go 1.27` module, so CI and the new make lint/fmt targets install it from source with the 1.27 toolchain instead of using golangci-lint-action.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add golangci-lint; fix all the things