tile,config: serve redacted config export on the log index page - #8
Merged
Conversation
Add config.Config.Redacted(), a public-safe view of the running configuration built as an allowlist: only fields that are neither secrets, filesystem paths, nor internal bind addresses are copied across, so a newly added field is excluded by default rather than leaking by accident. Dropped: data_dir, all seed/key/TLS paths, every *_path field, and the acme/monitoring/metrics/sign-subtree listen addresses (only external_url values are exposed). cmd/cactus marshals cfg.Redacted() and hands the JSON to the tile server via WithConfigJSON; the read-path server stays decoupled from config and just serves the bytes at GET /config (404 when unset). The browser UI gains a collapsible Configuration panel that fetches and displays it. Tests: a leak guard fills every secret/path/listen field with a sentinel and asserts none survive redaction; tile tests cover /config enabled and disabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add config.Config.Redacted(), a public-safe view of the running configuration built as an allowlist: only fields that are neither secrets, filesystem paths, nor internal bind addresses are copied across, so a newly added field is excluded by default rather than leaking by accident. Dropped: data_dir, all seed/key/TLS paths, every *_path field, and the acme/monitoring/metrics/sign-subtree listen addresses (only external_url values are exposed).
cmd/cactus marshals cfg.Redacted() and hands the JSON to the tile server via WithConfigJSON; the read-path server stays decoupled from config and just serves the bytes at GET /config (404 when unset). The browser UI gains a collapsible Configuration panel that fetches and displays it.
Tests: a leak guard fills every secret/path/listen field with a sentinel and asserts none survive redaction; tile tests cover /config enabled and disabled.