Open
Conversation
duaraghav8
requested changes
Jan 14, 2026
| " check mcpungle server logs for any errors from this MCP server", | ||
| " check mcpungle server logs for any errors from this MCP server"+ | ||
| " update the MCP_SERVER_INIT_REQ_TIMEOUT_SEC env var to change the timeout,"+ | ||
| " default is 30 seconds", |
Member
There was a problem hiding this comment.
Rather than hard-coding the value of 30 here, we should read it from the constant declared so that it acts as the source of truth.
I recommend that you move the McpServerInitRequestTimeoutSecondsDefault = 30 const declaration inside pkg/types/mcp_server.go file. This package contains all definitions that are shared between the CLI & server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updated default init request timeout to 30 seconds and changed corresponding messages and comments