Conversation
| @@ -0,0 +1,127 @@ | |||
| package docs | |||
There was a problem hiding this comment.
Is it idiomatic to put swagger stuff inside a docs package in go?
Because currently there's development.md documentation file inside the docs/ directory.
I don't want to cram both go code and MD files inside the docs/ folder so either the go code can be moved to a different directory or the MD file can be.
There was a problem hiding this comment.
I love the format of this project, where you keep your markdown file outside to find easily
all of your api docs / go docs can go to dir/docs , thats my suggestion, open for your thoughts.
There was a problem hiding this comment.
also this is in internal/docs not docs in root of repo
| got := deriveTags(tt.path) | ||
| assert.Equal(t, tt.want, got, "deriveTags(%q)", tt.path) | ||
| } | ||
| } |
There was a problem hiding this comment.
Since we've decided to remove the vendor/ directory, you can remove vendor from this PR as well.
There was a problem hiding this comment.
i will rebase this branch, once #44 this merged
|
I am still reviewing this PR. Right now I just added my initial thoughts. I will notify you here once I've completed my review @ankittk |
|
I just merged your other PR, so this one now has some conflicts with base that need to be fixed. |
ankittk
force-pushed
the
ankittk-add-openapi-spec
branch
from
f4dce02 to
474a526
Compare
|
@duaraghav8 fixed the conflict, let me know if you have any swagger requested change. |
|
@duaraghav8 did you get chance to test this? |
duaraghav8
force-pushed
the
main
branch
3 times, most recently
from
67f2579 to
6709e3a
Compare
duaraghav8
force-pushed
the
main
branch
2 times, most recently
from
e6f9f3d to
321f552
Compare
2 participants
this serves at