-
Notifications
You must be signed in to change notification settings - Fork 117
feat: Support YAML for MCP server configuration #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zyfy29
wants to merge
4
commits into
mcpjungle:main
Choose a base branch
from
zyfy29:feat-yaml-config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
55e15f7
feat: Support YAML for MCP server configuration
zyfy29 d687dad
Merge remote-tracking branch 'origin/main' into feat-yaml-config
894ef74
Merge remote-tracking branch 'origin/main' into feat-yaml-config
13acdc5
feat: Generic configuration file reader for JSON and YAML formats
zyfy29 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| package cmd | ||
|
|
||
| import ( | ||
| "strings" | ||
| "testing" | ||
|
|
||
| "github.com/mcpjungle/mcpjungle/pkg/types" | ||
| ) | ||
|
|
||
| func TestReadMcpServerConfigJson(t *testing.T) { | ||
| input := `{ | ||
| "name": "test_server", | ||
| "transport": "stdio", | ||
| "description": "Test JSON server", | ||
| "command": "node", | ||
| "args": ["server.js"], | ||
| "env": {"NODE_ENV": "test"} | ||
| }` | ||
|
|
||
| reader := strings.NewReader(input) | ||
| got, err := readMcpServerConfigJson(reader) | ||
| if err != nil { | ||
| t.Fatalf("readMcpServerConfigJson() error = %v", err) | ||
| } | ||
|
|
||
| expected := types.RegisterServerInput{ | ||
| Name: "test_server", | ||
| Transport: "stdio", | ||
| Description: "Test JSON server", | ||
| Command: "node", | ||
| Args: []string{"server.js"}, | ||
| Env: map[string]string{"NODE_ENV": "test"}, | ||
| } | ||
|
|
||
| if got.Name != expected.Name { | ||
| t.Errorf("Name = %q, want %q", got.Name, expected.Name) | ||
| } | ||
| if got.Transport != expected.Transport { | ||
| t.Errorf("Transport = %q, want %q", got.Transport, expected.Transport) | ||
| } | ||
| if got.Description != expected.Description { | ||
| t.Errorf("Description = %q, want %q", got.Description, expected.Description) | ||
| } | ||
| if got.Command != expected.Command { | ||
| t.Errorf("Command = %q, want %q", got.Command, expected.Command) | ||
| } | ||
| if len(got.Args) != len(expected.Args) || got.Args[0] != expected.Args[0] { | ||
| t.Errorf("Args = %v, want %v", got.Args, expected.Args) | ||
| } | ||
zyfy29 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| if got.Env["NODE_ENV"] != expected.Env["NODE_ENV"] { | ||
| t.Errorf("Env = %v, want %v", got.Env, expected.Env) | ||
| } | ||
| } | ||
|
|
||
| func TestReadMcpServerConfigYaml(t *testing.T) { | ||
| input := `name: test_server | ||
| transport: stdio | ||
| description: Test YAML server | ||
| command: node | ||
| args: | ||
| - server.js | ||
| env: | ||
| NODE_ENV: test` | ||
|
|
||
| reader := strings.NewReader(input) | ||
| got, err := readMcpServerConfigYaml(reader) | ||
| if err != nil { | ||
| t.Fatalf("readMcpServerConfigYaml() error = %v", err) | ||
| } | ||
|
|
||
| expected := types.RegisterServerInput{ | ||
| Name: "test_server", | ||
| Transport: "stdio", | ||
| Description: "Test YAML server", | ||
| Command: "node", | ||
| Args: []string{"server.js"}, | ||
| Env: map[string]string{"NODE_ENV": "test"}, | ||
| } | ||
|
|
||
| if got.Name != expected.Name { | ||
| t.Errorf("Name = %q, want %q", got.Name, expected.Name) | ||
| } | ||
| if got.Transport != expected.Transport { | ||
| t.Errorf("Transport = %q, want %q", got.Transport, expected.Transport) | ||
| } | ||
| if got.Description != expected.Description { | ||
| t.Errorf("Description = %q, want %q", got.Description, expected.Description) | ||
| } | ||
| if got.Command != expected.Command { | ||
| t.Errorf("Command = %q, want %q", got.Command, expected.Command) | ||
| } | ||
| if len(got.Args) != len(expected.Args) || got.Args[0] != expected.Args[0] { | ||
| t.Errorf("Args = %v, want %v", got.Args, expected.Args) | ||
| } | ||
zyfy29 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| if got.Env["NODE_ENV"] != expected.Env["NODE_ENV"] { | ||
| t.Errorf("Env = %v, want %v", got.Env, expected.Env) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point, do you think it is better to take out the whole configuration parsing logic into a separate package?
There are also some other commands that now rely on finding & parsing configurations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this logic should be reuseble.