use PhoenixProfiler on the Endpoint

[mcrumm]

No description provided.

[leandrocp]

Seems like there's a race condition here, the toolbar is mounted before telemetry has a chance to collect the event [:phoenix_profiler, :endpoint, :exception] so profile.data[:exception] is always null at this point.

I'm assuming that http://localhost:4000/errors/assign-not-available should populate @exits considering

phoenix_profiler/lib/phoenix_profiler/endpoint.ex

Line 55 in ae6ca03

telemetry_execute(:exception, %{duration: duration(start_time)}, %{

and

phoenix_profiler/lib/phoenix_profiler/telemetry.ex

Line 43 in ae6ca03

{:keep, %{exception: Map.take(meta, [:kind, :reason, :stacktrace])}}

[mcrumm]

@leandrocp You are correct– the toolbar cannot render the error for its own request because the Phoenix.Endpoint.RenderErrors module takes over sending the response. To account for this, the private late_collect/3 function on the profiler endpoint is invoked after the response has been sent, which allows us to collect additional information about the request to be viewed later.

I think you are also correct about the race condition tho– we are racing the late write to ETS and that's why we are getting back profile data without the exception.

But now I think I have an idea of how to get the tests passing, stand by! :)

[leandrocp]

Hey @mcrumm just tested this PR on a real project and it looks good to me 👍🏻

[mcrumm]

@leandrocp Thanks for testing it out! Yes, things seem to work fine but the Heisenbugs are forcing me to question some earlier decisions. I just had a nice chat with @elbow-jason who gave me some ideas that I hope to experiment with soon! :)