imgtool: Add TLV IDs for SHA3 in image.py#2679
Open
zhovtobruhd wants to merge 1 commit intomcu-tools:mainfrom
Open
imgtool: Add TLV IDs for SHA3 in image.py#2679zhovtobruhd wants to merge 1 commit intomcu-tools:mainfrom
zhovtobruhd wants to merge 1 commit intomcu-tools:mainfrom
Conversation
d3zd3z
requested changes
Mar 27, 2026
Member
d3zd3z
left a comment
d3zd3z
left a comment
There was a problem hiding this comment.
The commit text itself needs two things:
- a more full description. The description you have as the first comment here is a good starting point. The commit text should describe why the change is needed, not just what it is.
- A Signed-off-by line at the end.
| 'SHA256': 0x10, | ||
| 'SHA384': 0x11, | ||
| 'SHA512': 0x12, | ||
| 'SHA3_256': 0x13, |
Member
There was a problem hiding this comment.
To truly reserve these, they should added to boot/bootutil/include/bootutil/image.h as that is the authoritative list. They should also be added to docs/design.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Infineon Technologies is working on a feature that involves SHA3 hashes. We are known to have our own fork of imgtool, but we pull sometimes features from the upstream. For that reason, we intend to reserve TLV IDs for SHA3 hashes for future PRs when we need to add features to upstream.