Skip to content

boot:crypto Add custom crypto support#2680

Open
OleksandrShkurchenko wants to merge 1 commit intomcu-tools:mainfrom
OleksandrShkurchenko:custom_crypto_pr
Open

boot:crypto Add custom crypto support#2680
OleksandrShkurchenko wants to merge 1 commit intomcu-tools:mainfrom
OleksandrShkurchenko:custom_crypto_pr

Conversation

@OleksandrShkurchenko
Copy link
Copy Markdown

@OleksandrShkurchenko OleksandrShkurchenko commented Mar 30, 2026

The MCUBOOT_USE_CUSTOM_CRYPTO option allows to implement a custom
backend that lets users plug in any crypto library, hardware
accelerator, proprietary SDK, or another software implementation
without modifying MCUboot's own source.

Copy link
Copy Markdown
Member

@d3zd3z d3zd3z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A minor textual change, and adding CI support.

In addition, can you please format the commit text to be less than 72 columns.

Comment thread docs/custom_crypto.md Outdated
Comment thread sim/Cargo.toml
Comment thread boot/bootutil/src/encrypted_psa.c Outdated
Comment thread boot/bootutil/include/bootutil/crypto/sha.h Outdated
Comment thread boot/bootutil/include/bootutil/crypto/ecdsa.h Outdated
@nordicjm nordicjm requested a review from de-nordic April 9, 2026 14:52
Comment thread docs/custom_crypto.md Outdated
Comment thread .github/workflows/sim.yaml Outdated
The `MCUBOOT_USE_CUSTOM_CRYPTO` option allows to implement a custom
backend that lets users plug in any crypto library, hardware
accelerator, proprietary SDK, or another software implementation
without modifying MCUboot's own source.

Signed-off-by: Oleksandr Shkurchenko <Oleksandr.Shkurchenko@infineon.com>
Copy link
Copy Markdown
Member

@d3zd3z d3zd3z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

return mbedtls_md_hmac_update(ctx, data, data_length);
}

static inline int bootutil_hmac_sha256_finish(bootutil_hmac_sha256_context *ctx,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should have a comment explaining why we ignore taglen, and specifically, what taglen mbedtls is expecting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants