bootutil: mynewt: Fix boot_serial unit tests#2711
Open
sjanc wants to merge 1 commit intomcu-tools:mainfrom
Open
bootutil: mynewt: Fix boot_serial unit tests#2711sjanc wants to merge 1 commit intomcu-tools:mainfrom
sjanc wants to merge 1 commit intomcu-tools:mainfrom
Conversation
Contributor
Author
|
@m-gorecki FYI |
Member
|
For example, here is a more detailed commit text, feel free to use and/or adapt. |
Commit e015209 ("bootutil: mynewt: Improve BOOTUTIL configuration") added a pkg.source_files.!BOOT_LOADER override so that applications depending on bootutil only build bootutil_public.c, avoiding the need to set bootloader-only syscfgs for plain application builds. This override also fires when the boot_serial test package (pkg.type: unittest) is built, since BOOT_LOADER is not defined in that case. The result is that the unittest binary is linked against only bootutil_public.c and fails to resolve the rest of the bootutil symbols it exercises. Restrict the override to non-SELFTEST builds so unit tests get the full bootutil source list while application builds remain unaffected. Signed-off-by: Szymon Janc <szymon.janc@codecoup.pl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When in unittest we shall include all sources.