sim: replace deprecated rand 0.9 APIs#2715
Open
d3zd3z wants to merge 1 commit intomcu-tools:mainfrom
Open
Conversation
`rand::thread_rng` was renamed to `rand::rng`, and `Rng::gen_range` to `Rng::random_range`, in rand 0.9. The simulator pinned to 0.9 in a recent dependabot bump, so the old names now emit deprecation warnings. Signed-off-by: David Brown <david.brown@linaro.org> Assisted-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates simulator image logic to use the non-deprecated rand 0.9 APIs, eliminating deprecation warnings after the dependency bump from rand 0.8.x to 0.9.x.
Changes:
- Replace
rand::thread_rng()withrand::rng() - Replace
Rng::gen_range(...)withRng::random_range(...)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nordicjm
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rand::thread_rng()withrand::rng()andRng::gen_rangewithRng::random_rangeinsim/src/image.rs— both were renamed in rand 0.9 and now emit deprecation warnings after the recent dependabot bump from 0.8.5 to 0.9.3.Test plan
cargo build(in repo root) is warning-free apart from the pre-existing C-sideranlib: ... has no symbolsnotes.