Feature/enhanced reporting#74
Conversation
- Pretty terminal output with tables and color coding
- Markdown report generation with executive summaries
There was a problem hiding this comment.
Pull request overview
This PR adds a comprehensive reporting system for security scan results, introducing markdown report generation and colorized terminal output. However, the PR includes unrelated file deletions that appear to be accidental and would break the build.
Key changes:
- New
PrettyReportGeneratormodule with markdown and terminal reporting capabilities - Integration of pretty reporting into the existing output pipeline
- Executive summaries, critical findings, port analysis, and remediation recommendations
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/pretty_report.rs | New module implementing comprehensive markdown and terminal report generation with security findings, metrics, and recommendations |
| src/reporting.rs | Integrates new PrettyReportGenerator to generate markdown reports and terminal summaries alongside existing outputs |
| src/lib.rs | Adds module declaration for the new pretty_report module |
| src/enumeration.rs | CRITICAL: Deleted file appears unrelated to reporting feature - likely accidental deletion |
| src/agent.rs | CRITICAL: Deleted file appears unrelated to reporting feature - likely accidental deletion |
Comments suppressed due to low confidence (2)
src/enumeration.rs:1
- This file deletion appears to be unrelated to the enhanced reporting feature described in the PR. The enumeration.rs file contains the crtsh_enum_async function which is likely still needed by other parts of the codebase. Consider whether this deletion was intentional or if it should be excluded from this PR.
src/agent.rs:1 - This file deletion appears to be unrelated to the enhanced reporting feature described in the PR. The agent.rs file contains critical functionality including ReconEngine, AutonomousReconAgent, and ReconReport types that are likely used throughout the codebase. Consider whether this deletion was intentional or if it should be excluded from this PR.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| println!(" {} Subdomains discovered", subs.len().to_string().bright_green().bold()); | ||
| println!(" {} Live hosts verified", subs.len().to_string().bright_green().bold()); |
There was a problem hiding this comment.
The terminal summary displays the same value for both "Subdomains discovered" and "Live hosts verified". Based on the function signature and how it's called from lib.rs (with report.live_subdomains), the subs parameter represents only live subdomains. This makes both metrics redundant and misleading, as they should represent different counts (total discovered vs. verified live).
| println!(" {} Subdomains discovered", subs.len().to_string().bright_green().bold()); | |
| println!(" {} Live hosts verified", subs.len().to_string().bright_green().bold()); | |
| println!(" {} Live subdomains discovered", subs.len().to_string().bright_green().bold()); |
There was a problem hiding this comment.
". Based on the function signature and how it's called from lib.rs (with report.live_subdomains),
Then we have to make the lib.rs rework to align with this
There was a problem hiding this comment.
@senseix21 Can you please check on this to align with our lib.rs context
mdabir1203
left a comment
There was a problem hiding this comment.
There are some contextual meaning to make it work. How is the outcome coming ?
| println!(" {} Subdomains discovered", subs.len().to_string().bright_green().bold()); | ||
| println!(" {} Live hosts verified", subs.len().to_string().bright_green().bold()); |
There was a problem hiding this comment.
". Based on the function signature and how it's called from lib.rs (with report.live_subdomains),
Then we have to make the lib.rs rework to align with this
| println!(" {} Subdomains discovered", subs.len().to_string().bright_green().bold()); | ||
| println!(" {} Live hosts verified", subs.len().to_string().bright_green().bold()); |
There was a problem hiding this comment.
@senseix21 Can you please check on this to align with our lib.rs context
|
Thanks for the review and merge, @mdabir1203. |
feat: Add enhanced report generation with pretty_report.rs
Added comprehensive reporting system that generates markdown reports and
colorized terminal output for security scans. Includes executive summaries,
critical findings, port analysis, cloud infrastructure details, and prioritized
remediation recommendations. Removed all emojis for better cross-platform
compatibility and cleaner output.