Skip to content

Feature/enhanced reporting#74

Merged
mdabir1203 merged 4 commits into
mdabir1203:mainfrom
senseix21:feature/enhanced-reporting
Dec 20, 2025
Merged

Feature/enhanced reporting#74
mdabir1203 merged 4 commits into
mdabir1203:mainfrom
senseix21:feature/enhanced-reporting

Conversation

@senseix21

Copy link
Copy Markdown
Contributor

feat: Add enhanced report generation with pretty_report.rs

Added comprehensive reporting system that generates markdown reports and
colorized terminal output for security scans. Includes executive summaries,
critical findings, port analysis, cloud infrastructure details, and prioritized
remediation recommendations. Removed all emojis for better cross-platform
compatibility and cleaner output.

     - Pretty terminal output with tables and color coding
     - Markdown report generation with executive summaries
Copilot AI review requested due to automatic review settings December 19, 2025 06:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a comprehensive reporting system for security scan results, introducing markdown report generation and colorized terminal output. However, the PR includes unrelated file deletions that appear to be accidental and would break the build.

Key changes:

  • New PrettyReportGenerator module with markdown and terminal reporting capabilities
  • Integration of pretty reporting into the existing output pipeline
  • Executive summaries, critical findings, port analysis, and remediation recommendations

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/pretty_report.rs New module implementing comprehensive markdown and terminal report generation with security findings, metrics, and recommendations
src/reporting.rs Integrates new PrettyReportGenerator to generate markdown reports and terminal summaries alongside existing outputs
src/lib.rs Adds module declaration for the new pretty_report module
src/enumeration.rs CRITICAL: Deleted file appears unrelated to reporting feature - likely accidental deletion
src/agent.rs CRITICAL: Deleted file appears unrelated to reporting feature - likely accidental deletion
Comments suppressed due to low confidence (2)

src/enumeration.rs:1

  • This file deletion appears to be unrelated to the enhanced reporting feature described in the PR. The enumeration.rs file contains the crtsh_enum_async function which is likely still needed by other parts of the codebase. Consider whether this deletion was intentional or if it should be excluded from this PR.
    src/agent.rs:1
  • This file deletion appears to be unrelated to the enhanced reporting feature described in the PR. The agent.rs file contains critical functionality including ReconEngine, AutonomousReconAgent, and ReconReport types that are likely used throughout the codebase. Consider whether this deletion was intentional or if it should be excluded from this PR.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/pretty_report.rs
Comment thread src/pretty_report.rs Outdated
Comment on lines +353 to +354
println!(" {} Subdomains discovered", subs.len().to_string().bright_green().bold());
println!(" {} Live hosts verified", subs.len().to_string().bright_green().bold());

Copilot AI Dec 19, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The terminal summary displays the same value for both "Subdomains discovered" and "Live hosts verified". Based on the function signature and how it's called from lib.rs (with report.live_subdomains), the subs parameter represents only live subdomains. This makes both metrics redundant and misleading, as they should represent different counts (total discovered vs. verified live).

Suggested change
println!(" {} Subdomains discovered", subs.len().to_string().bright_green().bold());
println!(" {} Live hosts verified", subs.len().to_string().bright_green().bold());
println!(" {} Live subdomains discovered", subs.len().to_string().bright_green().bold());

Copilot uses AI. Check for mistakes.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

". Based on the function signature and how it's called from lib.rs (with report.live_subdomains),

Then we have to make the lib.rs rework to align with this

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@senseix21 Can you please check on this to align with our lib.rs context

Comment thread src/pretty_report.rs

@mdabir1203 mdabir1203 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some contextual meaning to make it work. How is the outcome coming ?

Comment thread src/pretty_report.rs Outdated
Comment on lines +353 to +354
println!(" {} Subdomains discovered", subs.len().to_string().bright_green().bold());
println!(" {} Live hosts verified", subs.len().to_string().bright_green().bold());

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

". Based on the function signature and how it's called from lib.rs (with report.live_subdomains),

Then we have to make the lib.rs rework to align with this

Comment thread src/pretty_report.rs Outdated
Comment on lines +353 to +354
println!(" {} Subdomains discovered", subs.len().to_string().bright_green().bold());
println!(" {} Live hosts verified", subs.len().to_string().bright_green().bold());

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@senseix21 Can you please check on this to align with our lib.rs context

@mdabir1203
mdabir1203 merged commit 7ac9020 into mdabir1203:main Dec 20, 2025
3 checks passed
@senseix21

Copy link
Copy Markdown
Contributor Author

Thanks for the review and merge, @mdabir1203.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants