Enable ignoring HTML classes - #15
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an ignore_classes option to HTML normalization so that content comparison can ignore all HTML class attributes on remaining elements (after applying ignore selectors), enabling more stable diffs for class-heavy pages.
Changes:
- Extend page configuration to include
ignore_classes(parsed from TOML, defaulting toFalse). - Thread
ignore_classesthrough the Gleam server code into the Elixir/Floki HTML normalization implementation. - Update and add tests to cover both class-stripping and non-stripping behavior.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/server_test.gleam | Updates comparable-content tests for the new parameter; adds coverage for class stripping on/off. |
| src/ciele/server.gleam | Threads ignore_classes into comparable content generation; updates public API arity. |
| src/ciele/html.ex | Implements conditional stripping of class attributes via Floki traversal. |
| src/ciele/config.gleam | Extends Page config/type and TOML parsing to support ignore_classes. |
| gleam.toml | Bumps package version. |
| config/config.example.toml | Demonstrates the new ignore_classes configuration option. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for ignoring all HTML
classattributes during content comparison, controlled by a newignore_classesoption in the configuration.