Skip to content

Changeed Google Cloud Speech API's from beta to latest #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

copperorange
Copy link

Thank you for creating substream.
This change modifies the original implementation to cover the breaking changes made but the new google.cloud version.
This change requires review and all feedback is appreciated.

@mdegans
Copy link
Owner

mdegans commented Dec 10, 2020

Thanks for the PR, @copperorange . I'll be reviewing it this weekend if I get a chance. Glad you like the [project!

@mdegans mdegans self-requested a review December 10, 2020 00:43
@mdegans
Copy link
Owner

mdegans commented Dec 12, 2020

@copperorange

Just to update, it might be a few more weeks before I get a chance to take a look. I only need substream every once in a while when content doesn't have subtitles (looking at you, HBO, with the lack of accessability for GoT director's commentary). As soon as I'm able to legally backup said content, I'll test out your PR and merge it. Thanks again for the submission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants