Report testcase metrics and attribute adjustments #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our goal is to collect metrics from our tests to help us identify flaky and slow tests across branches. To accomplish this we need to emit testcase-level metrics. This PR introduces the sending of testcase-level metrics.
We are concerned about cardinality of the metrics and from the issues, I think this concern is shared by others. I'm happy to chat about which attributes are appropriate for metrics. We are happy to introduce a flag to control the attributes. The README has been updated to make it clear which attributes are on traces vs metrics.