-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add meta viewport support data #25392
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this PR seems to missing some references for the determined support statuses.
As we discussed on the BCD call, this PR is a starting point in a long investigation and testing process. All early browser versions I provided have some degree of uncertainty unless we actually test it. Unfortunately, I don’t have the resources for such testing. But I think “the first best guess” would still be useful.
When it comes to mobile browsers, the meta viewport was an opt-in solution (invented by Apple) for browsers to render adequately scaled pages on mobile. All early mobile browsers had to mimic Safari’s viewport implementation to be compatible with the mobile web of that time. Unfortunately, the early release notes are lacking details and cannot be used in the “if it’s not mentioned, then it’s not there” way. That’s why the first best guess here is:
The first mobile browsers of that time. By the way, here’s another PPK’s compat table I found that might be helpful. |
I haven’t done any testing. I only have release notes: |
My apologies, if we discussed to add specific version numbers, although we're not certain, then let's do this. Otherwise, I would prefer to test in some version we're certain it's supported, add a range using that version instead, and create an issue with the used test case for further narrowing down the versions in the future. |
Yep, there’s a high level of certainty that the initial mobile browsers were shipped with the viewport support. We can revisit it once we’ve done the testing. I brought it up again on today’s BCD call and got positive feedback from @Elchi3. With all that, I’m planning to resolve all comments regarding the initial support versions and address the |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM (*), but I have two remaining questions:
- Shouldn't all these viewport-related content values go below the
viewport
feature, even if syntactically they are values of thecontent
attribute? (@Elchi3 Wdyt?) - Should any of those version numbers be replaced with a range (
≤x
) if we're uncertain whether the feature was added in that exact version?
(*) I have only spot-checked some of the data based on the summary given in the referenced issue. If we already had the internal annotations field, we could record the confidence or reasoning for each support statement, but unfortunately we don't have it yet.
@Elchi3 @ddbeck @queengooborg Do you have an opinion on where the viewport-related |
We decided to restructure the viewport support data a bit, so marking it as a draft for now. |
ec68f8f
to
4c431d6
Compare
I moved all viewport members and values into a subfolder (
I wonder why the same principle works for input types but doesn’t for meta viewport members. Also, added support info for |
@pepelsbey The file path must reflect the BCD feature path. You named the subfeature |
@caugner but why does it work in the other case? The key in |
TIL about these special cases:
|
Would you recommend adding another special case (I don’t like it, to be honest) or getting rid of them altogether? I’ll bring this up next week. |
I would strongly recommend for all viewport subfeatures to have a common parent feature, so that you can easily list them on a single MDN page about meta viewport:
Instead of |
Summary
Adds missing support data for
<meta name="viewport">
.Test results and supporting details
This PR assumes that Mobile Safari 3 for iOS shipped the first
<meta name="viewport">
implementation, and all later released mobile browsers followed.There’s a
viewport-fit
feature that Safari 11 presumably shipped. I just learned that Chrome is planning to ship it soon, too.Related issues
Fixes #25311