Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(manifests)!: add top-level manifests folder + move Web App Manifest #26109

Merged
merged 6 commits into from
Mar 25, 2025
Merged

feat(manifests)!: add top-level manifests folder + move Web App Manifest #26109

merged 6 commits into from
Mar 25, 2025

Conversation

queengooborg
Copy link
Contributor

This PR introduces a top-level manifests/ folder. This folder will eventually store more types of manifests; currently, it only holds the webapp manifests, which were moved from html.manifest.

Fixes #18493.

@queengooborg queengooborg requested a review from Elchi3 March 4, 2025 10:40
@github-actions github-actions bot added schema Isses or pull requests regarding the JSON schema files used in this project. infra Infrastructure issues (npm, GitHub Actions, releases) of this project docs Issues or pull requests regarding the documentation of this project. linter Issues or pull requests regarding the tests / linter of the JSON files. bulk_update An update to a mass amount of data, or scripts/linters related to such changes scripts Issues or pull requests regarding the scripts in scripts/. size:l [PR only] 101-1000 LoC changed labels Mar 4, 2025
caugner
caugner requested changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like some occurrences of "manifest" were replaced with "manifests", that shouldn't have been replaced:

@caugner
Copy link
Contributor

caugner commented Mar 4, 2025

@Elchi3 @queengooborg Should this go into BCD 5.7 or 6.0?

@queengooborg queengooborg added the semver-major-bump A change that is potentially breaking for consumers label Mar 4, 2025
@queengooborg
Copy link
Contributor Author

This should go in v6.0 because html.manifests is a semver-enforced category!

@queengooborg queengooborg reopened this Mar 4, 2025
@github-actions github-actions bot added size:xs [PR only] 0-6 LoC changed size:l [PR only] 101-1000 LoC changed and removed size:l [PR only] 101-1000 LoC changed size:xs [PR only] 0-6 LoC changed labels Mar 4, 2025
@caugner caugner added this to the BCD 6.0 milestone Mar 4, 2025
@github-actions github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Mar 6, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript and removed bulk_update An update to a mass amount of data, or scripts/linters related to such changes merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. labels Mar 6, 2025
@github-actions github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Mar 11, 2025
@github-actions GitHub Actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. labels Mar 25, 2025
@caugner

This comment was marked as resolved.

Sign in to view
caugner
caugner approved these changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit.

@github-actions github-actions bot removed the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Mar 25, 2025
@caugner caugner changed the title Introduce top-level Manifest folder feat(manifests)!: add manifests/ folder + move html/manifest/ to manifests/webapp/ Mar 25, 2025
@github-actions github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Mar 25, 2025
@github-actions GitHub Actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed linter Issues or pull requests regarding the tests / linter of the JSON files. merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. labels Mar 25, 2025
@caugner caugner merged commit 248a906 into main Mar 25, 2025
10 checks passed
@caugner caugner deleted the web-app-manifest branch March 25, 2025 13:46
@caugner caugner changed the title feat(manifests)!: add manifests/ folder + move html/manifest/ to manifests/webapp/ feat(manifests)!: add top-level manifests folder + move Web App Manifest Mar 25, 2025
@mdn-bot mdn-bot mentioned this pull request Mar 25, 2025
Merged
@caugner caugner mentioned this pull request Mar 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Elchi3 Elchi3 Elchi3 approved these changes

@caugner caugner caugner approved these changes

Assignees
No one assigned
Labels
docs Issues or pull requests regarding the documentation of this project. infra Infrastructure issues (npm, GitHub Actions, releases) of this project schema Isses or pull requests regarding the JSON schema files used in this project. scripts Issues or pull requests regarding the scripts in scripts/. semver-major-bump A change that is potentially breaking for consumers size:l [PR only] 101-1000 LoC changed
Projects
None yet
Milestone
BCD 6.0
Development

Successfully merging this pull request may close these issues.

Introduce top-level manifests/ folder
3 participants
@queengooborg @caugner @Elchi3