-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chrome 125 + Safari 18.2 support startViewTransition() with object #26193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should follow the parameter data guidelines, https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines/index.md#parameters-and-parameter-object-features
@Elchi3 This one is a bit tricky, as the method accepts either a ViewTransitionUpdateCallback or a StartViewTransitionOptions object, but in both cases the parameter is called
But since CSS View Transitions Level 1 calls the parameter |
Yes, I think that sounds reasonable to me. |
…r sub-features Co-authored-by: Florian Scholz <[email protected]>
4426ddb
to
325b427
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 👍
Summary
Adds
startViewTransition()
subfeature for accepting an options object.Test results and supporting details
Chromium impl: https://chromestatus.com/feature/5089552511533056
WebKit impl: WebKit/WebKit@c6cadba (in 620.1.2 before Safari 18.2)
Related issues
See: