Update Deno data for api.Window #26265
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
data:api
|
@bartlomieju @lucacasonato Could you please take a look if these changes make sense to you? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update Deno data for
api.Window.Test results and supporting details
Mostly sets
version: false.Notable changes:
beforeunload_eventwas added in v1.27 (denoland/deno@06ccb6d)blurwas not available in v1.24 (see here, verified by runningtypeof self.blur, which givesundefined)closedis available since v1.0 (see here)error_eventwas added in v1.21 (denoland/deno@4d18f55)locationis actually available without runtime flag, but it does reflect the value of it.selfis available since v1.0 (see here)windowis available since v1.0 (see here)Verified by running
Object.getOwnPropertyNames(self).filter(a => a[0] === a[0].toLowerCase()).sort()in Deno 2.2.4, which seems to reflect https://github.com/denoland/deno/blob/60b502db80ea4524c8a5e316177f32329dc15a33/cli/tsc/dts/lib.deno.window.d.ts#L18-L72.Grouped diff:
Related issues