Bug-1657575 webRequest.handlerBehaviorChanged implementation #26266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebloor
added
the
data:webext
dotproto
suggested changes
Mar 21, 2025
webextensions/api/webRequest.json
Outdated
Comment on lines
1447
to
1450
| "firefox": { | ||
| "version_added": "45" | ||
| }, | ||
| "firefox_android": { | ||
| "version_added": "48" | ||
| "version_added": "138" | ||
| }, | ||
| "firefox_android": "mirror", |
There was a problem hiding this comment.
We should note that the method was exposed but did not function as expected. I have not tested this suggested JSON, but it should follow the format described in the compat data schema docs.
Suggested change
| "firefox": { | |
| "version_added": "45" | |
| }, | |
| "firefox_android": { | |
| "version_added": "48" | |
| "version_added": "138" | |
| }, | |
| "firefox_android": "mirror", | |
| "firefox": [ | |
| { | |
| "version_added": "138" | |
| }, | |
| { | |
| "version_added": "45", | |
| "partial_implementation": true, | |
| "note": "Exposed but non-functional" | |
| } | |
| ] | |
| "firefox_android": [ | |
| { | |
| "version_added": "138" | |
| }, | |
| { | |
| "version_added": "48", | |
| "partial_implementation": true, | |
| "note": "Exposed but non-functional" | |
| } | |
| ], |
There was a problem hiding this comment.
@dotproto almost, it's "notes" not "note"
github-actions
bot
added
size:m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the dev-docs-needed requirement for Bug 1657575 webRequest.handlerBehaviorChanged should clear caches, including stylesheet cache – the method was not implemented, contrary to the original browser compatibility data. The update records its incrementation as per the bug.
Related issues
PR for release note mdn/content#38744